Open
Conversation
This may break existing scripts passing the clipboard data as argument to the script instead of via stdin, as now we are parsing the arguments
thunder-coding
commented
Apr 3, 2025
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.0.0) | |||
| cmake_minimum_required(VERSION 3.25) | |||
Member
Author
There was a problem hiding this comment.
This change is because cmake 4 is now raising errors about older requirements for cmake version < 3.5.0. Arch has got cmake 4, so I am getting this error, we too probably will be getting update to cmake 4 for termux-packages soon
twaik
reviewed
Apr 4, 2025
Member
There was a problem hiding this comment.
Should this file (.editorconfig) be here?
Member
Author
There was a problem hiding this comment.
Yes, this is intentional. Should make setup process for everyone easier regardless of what editor they use. Most popular editors already support editorconfig: https://editorconfig.org/#pre-installed.
Just didn't find any reason to create a separate PR for a minor change. If you want to have a separate PR, I can split it up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related termux-api PR termux/termux-api#760
Additional TODOs after this PR is merged:
-swith termux-clipboard-set