Fixed(UsbAPI): Implement product/vendor ID support#824
Fixed(UsbAPI): Implement product/vendor ID support#824alexytomi wants to merge 1 commit intotermux:masterfrom
Conversation
|
I don't think that commit message quite follows the format we use. fix(api/usb): implement product/vendor ID support
Implement support for options added in API package:
https://github.com/termux/termux-api-package/commit/7531d577ffae5156206ecd8cd193d0d6673c2871might be closer to the convention, |
TomJo2000
left a comment
There was a problem hiding this comment.
I don't know enough Java to give more than some whitespace formatting changes as suggestions, but this seems reasonable to me.
431ac70 to
b40a175
Compare
I was copying what I saw as the commit history of this repo That message looks a lot better though, I couldn't think up of a better one, thanks! |
|
We can't exactly fix bad history but we can always try writing better history in the future. |
Implement support for options added in API package: termux/termux-api-package@7531d57
b40a175 to
dd94c3b
Compare
I completely forgot to fix the formatting, my bad. Also fixed a few other unrelated formatting errors. |
It happens. |
|
I found an issue, this only functions for If someone manually provided only the vendorId with their own termux-api invocation, it would not match for it. |
|
Changes for that commit were already implemented in #759 with further enhancements. So closing this. Termux app and plugins all follow the commit convention defined in https://github.com/termux/termux-app?tab=readme-ov-file#commit-messages-guidelines |
No description provided.