refactor(agent): remove dead code and integrate McpToolsHandler #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --tui flag to force TUI mode - REPL is now default when running terraphim-agent without arguments - TUI mode requires a server to be running at localhost:8000 - Update help text to reflect new default behavior - All tests passing
- Fix needless_borrows_for_generic_args in terraphim_update (4 instances) - Fix unnecessary_unwrap in terraphim-session-analyzer tests - Fix needless_question_mark in terraphim_agent repl/mcp_tools - Fix wildcard_in_or_patterns in terraphim_agent repl/mcp_tools - Add #[allow(dead_code)] for McpToolsHandler (feature not used) - Remove deprecated rocksdb feature tests (causing unexpected_cfgs errors) - All clippy checks now pass
Remove dead code warnings and properly integrate McpToolsHandler: - Remove #[allow(dead_code)] from McpToolsHandler (now actively used) - Integrate McpToolsHandler into ReplHandler for MCP commands - Refactor wizard to use into_result() pattern (cleaner error handling) - Remove unused error variants: PathNotFound, Config, RoleExists, Network - Remove unused functions: prompt_confirm, prompt_input - Gate test-only function is_first_run with #[cfg(test)] Changes: - mcp_tools.rs: Remove dead_code attributes, simplify error handling - handler.rs: Add mcp_handler field, use in MCP command handlers - wizard.rs: Use into_result() instead of manual match blocks - mod.rs: Remove unused OnboardingError variants - validation.rs: Remove PathNotFound variant - prompts.rs: Remove unused utility functions - service.rs: Remove dead_code attributes from now-used methods Verification: - All 134 unit tests pass - All 11 integration tests pass - No breaking changes - Code quality improved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove dead code warnings and properly integrate McpToolsHandler into the REPL system.
Changes
McpToolsHandler Integration
Wizard Refactoring
Dead Code Removal
Verification
Impact
Ready for review and merge.