Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should introduce a new feature for the framework, that can help you reviewing your patterns in your library.
Simple usage example:
tpframework patternrepair -l php -p 1 --skip-readmeThis command will take a look at PHP pattern 1 and tries to repair it,
--skip-readmetells the tool to skip generating a new README file for that pattern.Repair a pattern means:
expectation:expectationis the opposite ofproperties:negative_test_caseAt the moment this feature is only supported for PHP patterns, the feature was developed as part of reviewing all PHP patterns.
This PR aims to change the role of the
PatternandInstanceclass in the framework a little bit. It enables the possibility, to consider the pattern and the instance without handling the filesystem paths. i.e. theInstanceobject saves all the paths from the instance JSON as relative paths to a base path. This should make it possible to simplify some of the file system operations.I would suggest merging this PR after the CPG only feature, as I expect a few merge conflicts