Selenium support user-provided network #1207
Merged
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, SeleniumRecordingContainer always created a new internal network, ignoring any network provided via withNetwork() or withNetworkMode(). This broke scenarios where Selenium needed to communicate with other containers on a shared network. The fix: - Only create an internal network if user didn't provide one - Use the user-provided network for both Selenium and ffmpeg containers - Only stop the network on cleanup if we created it internally Fixes testcontainers#844
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cristianrgreco
added
bug
| const { exitCode } = await container.exec(["getent", "hosts", "webserver"]); | ||
| expect(exitCode).toBe(0); | ||
|
|
||
| await container.stop(); |
Collaborator
There was a problem hiding this comment.
Nit: can use await using container and drop this stop
cristianrgreco
approved these changes
Dec 25, 2025
cristianrgreco
changed the title
Replace manual container.stop() with await using declaration for consistent resource management pattern across the test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #844
Previously,
SeleniumRecordingContaineralways created a new internal network, ignoring any network provided viawithNetwork()orwithNetworkMode(). This broke scenarios where Selenium needed to communicate with other containers on a shared network.Changes
createNetworkIfNeeded()helper that only creates a network if the user didn't provide onewithNetworkMode()instead ofwithNetwork()for flexibilityinternalNetworkoptional inStartedSeleniumRecordingContainer- only cleaned up if we created itTest plan