fix(modules): Mailpit Container#625
Merged
alexanderankin merged 11 commits intotestcontainers:mainfrom Jun 30, 2024
Merged
Conversation
975d556 to
cfce31d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=======================================
Coverage ? 76.26%
=======================================
Files ? 11
Lines ? 573
Branches ? 83
=======================================
Hits ? 437
Misses ? 110
Partials ? 26 ☔ View full report in Codecov by Sentry. |
cfce31d to
f4b2278
Compare
5d08557 to
41b6771
Compare
41b6771 to
2dfd1c0
Compare
oliverlambson
commented
Jun 30, 2024
Comment on lines
+35
to
+40
| class MailpitUser(NamedTuple): | ||
| """Mailpit user for authentication | ||
|
|
||
| Helper class to define a user for Mailpit authentication. | ||
|
|
||
| This is just a named tuple for username and password. |
Contributor
Author
There was a problem hiding this comment.
I imagine this could be a controversial addition, since it's the first class being exported from community modules that isn't a container.
The reason I've done this is because it's a more descriptive and intuitive datatype (to me):
- users: list[tuple[str, str]] | None
+ users: list[MailpitUser] | None
oliverlambson
commented
Jun 30, 2024
Contributor
Author
There was a problem hiding this comment.
I've also added a py.typed as this module is fully type-hinted (see #504). Running mypy on it reveals the type hint issues in core, but raises no issues within this module
Tranquility2
pushed a commit
to Tranquility2/testcontainers-python
that referenced
this pull request
Jun 30, 2024
Fixes testcontainers#626 - [x] Your PR title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) syntax as we make use of this for detecting Semantic Versioning changes. - [x] Your PR allows maintainers to edit your branch, this will speed up resolving minor issues! - [x] The new container is implemented under `modules/*` - Your module follows [PEP 420](https://peps.python.org/pep-0420/) with implicit namespace packages (if unsure, look at other existing community modules) - Your package namespacing follows `testcontainers.<modulename>.*` and you DO NOT have an `__init__.py` above your module's level. - Your module has it's own tests under `modules/*/tests` - Your module has a `README.rst` and hooks in the `.. auto-class` and `.. title` of your container - Implement the new feature (typically in `__init__.py`) and corresponding tests. - [x] Your module is added in `pyproject.toml` - it is declared under `tool.poetry.packages` - see other community modules - it is declared under `tool.poetry.extras` with the same name as your module name, we still prefer adding _NO EXTRA DEPENDENCIES_, meaning `mymodule = []` is the preferred addition (see the notes at the bottom) - [x] (seems to not be needed anymore) The `INDEX.rst` at the project root includes your module under the `.. toctree` directive - [x] Your branch is up to date (or we'll use GH's "update branch" function through the UI) --------- Co-authored-by: Dave Ankin <daveankin@gmail.com>
alexanderankin
pushed a commit
that referenced
this pull request
Jul 2, 2024
🤖 I have created a release *beep* *boop* --- ## [4.7.1](testcontainers-v4.7.0...testcontainers-v4.7.1) (2024-07-02) ### Bug Fixes * **core:** bad rebase from [#579](#579) ([#635](#635)) ([4766e48](4766e48)) * **modules:** Mailpit Container ([#625](#625)) ([0b866ff](0b866ff)) * **modules:** SFTP Server Container ([#629](#629)) ([2e7dbf1](2e7dbf1)) * **network:** Now able to use Network without context, and has labels to be automatically cleaned up ([#627](#627)) ([#630](#630)) ([e93bc29](e93bc29)) * **postgres:** get_connection_url(driver=None) should return postgres://... ([#588](#588)) ([01d6c18](01d6c18)), closes [#587](#587) * update test module import ([#623](#623)) ([16f6ca4](16f6ca4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Container
Fixes #626
PR Checklist
as we make use of this for detecting Semantic Versioning changes.
modules/*(if unsure, look at other existing community modules)
testcontainers.<modulename>.*and you DO NOT have an
__init__.pyabove your module's level.modules/*/testsREADME.rstand hooks in the.. auto-classand.. titleof your container__init__.py) and corresponding tests.pyproject.tomltool.poetry.packages- see other community modulestool.poetry.extraswith the same name as your module name,we still prefer adding NO EXTRA DEPENDENCIES, meaning
mymodule = []is the preferred addition(see the notes at the bottom)
INDEX.rstat the project root includes your module under the.. toctreedirectivePreferred implementation
for the given tools you are triyng to implement.
testcontainers.