docs: example for configuring a custom DockerContainer#711
Open
vemonet wants to merge 3 commits intotestcontainers:mainfrom
Open
docs: example for configuring a custom DockerContainer#711vemonet wants to merge 3 commits intotestcontainers:mainfrom
vemonet wants to merge 3 commits intotestcontainers:mainfrom
Conversation
…ith exposed port and environment variable
|
Hi, I had the same "issue" as you few days ago, and I had to look into code to find out that DockerContainer class is much rich than what is displayed in docs. If I had a suggestion, I'd also add the volume mapping example, just for the sake of it. Volume mapping is a basic use case too, as the ones you provided. |
Tranquility2
approved these changes
Jun 29, 2025
Contributor
|
Looks like this needs some more work |
Author
|
@Tranquility2 it's litterally 10 lines in a readme of the most basic example of how most people will use this lib Should not be too hard to get right no? Note the one I wrote was almost a year ago, so the lib might have evolved since then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current examples for running a
DockerContainerare all usingwith DockerContainer(3 examples out of 3).But this is not the right way when someone wants to add some custom configuration (expose a port, define an environment variable), which is quite a regular use-case.
Newcomers reading this docs might get confused and will need to go through the process of finding out how to do this properly outside of the docs (e.g. this guy here #709 )
So I have added a basic example, feel free to change the docker image/port for something else