fix(tests): replace dind-test direct docker usage with sdk#750
Merged
alexanderankin merged 1 commit intotestcontainers:mainfrom Dec 15, 2024
Merged
fix(tests): replace dind-test direct docker usage with sdk#750alexanderankin merged 1 commit intotestcontainers:mainfrom
alexanderankin merged 1 commit intotestcontainers:mainfrom
Conversation
Contributor
Author
|
Not sure this is the best solution, I'm also considering using the image API to be more verbose. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage ? 85.37%
=======================================
Files ? 12
Lines ? 670
Branches ? 105
=======================================
Hits ? 572
Misses ? 75
Partials ? 23 ☔ View full report in Codecov by Sentry. |
alexanderankin
approved these changes
Dec 15, 2024
alexanderankin
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [4.9.1](testcontainers-v4.9.0...testcontainers-v4.9.1) (2025-01-21) ### Bug Fixes * milvus healthcheck: use correct requests errors ([#759](#759)) ([78b137c](78b137c)) * **mysql:** add dialect parameter instead of hardcoded mysql dialect ([#739](#739)) ([8d77bd3](8d77bd3)) * **tests:** replace dind-test direct docker usage with sdk ([#750](#750)) ([ace2a7d](ace2a7d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #749
Replace using
subprocess.runin the dind test with SDK to avoid the direct call to docker that enforces the developer to run sudoless docker.