fix: reject unsafe repository default branches before git switch - #341
Open
o-mid wants to merge 1 commit into
Open
fix: reject unsafe repository default branches before git switch#341o-mid wants to merge 1 commit into
o-mid wants to merge 1 commit into
Conversation
Story branches were already checked, but origin/${defaultBranch} was not,
so a stored default of main..evil could be passed to git as revision-range
syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses unsafe git start-points from a stored repository default branch.
Workspace prepare already rejected unsafe story branches, then passed
origin/${defaultBranch}togit switchwithout the same check. A default ofmain..evilis git range syntax.Prepare now rejects that class of default branch before clone. Valid hostile names such as
$(id)still pass because git is invoked as argv, not a shell string.Test plan
pnpm --filter @facility/api exec vitest run test/git-branch.test.tspnpm --filter @facility/api test$(id),release/2026, andfoo"barremain acceptedmain..evil,foo@{upstream}, andchore/../otherare rejected