fix: scope facility doctor agent checks to YAML frontmatter - #342
Open
o-mid wants to merge 1 commit into
Open
Conversation
Doctor was matching name, model, triggers, and forbidden keys across the prompt body, so a valid prompt could fail and a wrong frontmatter name could hide behind a line in the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses doctor false pass and false fail against the 0.12 agent contract.
facility doctorapplied name, model, trigger, and forbidden-key regexes to the whole agent file. Prompt text such as a GitHubpermissions:example failed the check, and a wrong frontmattername:could be hidden by repeating the expected name in the prompt. Quoted model ids with spaces also failed.Doctor now splits YAML frontmatter from the prompt, accepts
mcpanduitriggers (already valid at runtime), and accepts quoted model scalars.Test plan
pnpm --filter @theagilemonkeys/facility testpermissions:still passespermissions:still failsname: builderonly in the prompt does not satisfy builder.mdmodel: "gpt-5.6-sol with spaces"passesmcpanduitriggers passes