Stop double clicking on non-input next/previous buttons showing multiple steps#26
Closed
meh-uk wants to merge 5 commits intothecodemine:masterfrom
Closed
Stop double clicking on non-input next/previous buttons showing multiple steps#26meh-uk wants to merge 5 commits intothecodemine:masterfrom
meh-uk wants to merge 5 commits intothecodemine:masterfrom
Conversation
added 5 commits
January 12, 2012 10:36
Contributor
Author
|
Pull #34 is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you use a non-input element for the next/previous buttons (e.g. a link) you can get into a state where multiple steps are shown on the screen at once but only one is functional.
To prevent this from happening I've added some code so that the next/previous actions are only run if the links are enabled.
Sorry about the large number of commits, I have had to revert the last changes I sent as I foolishly didn't create a branch - the overall diff is what I want to push though.