Add Templates feature to foreman-proxy#519
Conversation
dcadf66 to
9a7993c
Compare
77b2cc9 to
6be7b5b
Compare
6be7b5b to
26ddc10
Compare
26ddc10 to
215ec14
Compare
215ec14 to
c5bb26e
Compare
|
Does templates need to be in the features.yaml? I do not see how the feature in this PR ensures foreman-proxy gets added. |
Yes, templates is declared in features.yaml under the foreman_proxy key (same pattern as bmc). I don't think we have a way to ensure if foreman-proxy gets added. |
713b3d9 to
ded1e9b
Compare
|
@ehelms Made some updates that ensures foreman-proxy gets added on the feature install. Not sure if that should be part of this PR. |
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
ded1e9b to
f0ba618
Compare
Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>
f0ba618 to
b20b505
Compare
There was a problem hiding this comment.
Do the changes to this file mean that if you do --add-feature templates on fresh, feature-less deployment, it will also enable the (base) foreman-proxy feature?
There was a problem hiding this comment.
I think that's wrong, this should be done by the user deliberately.
Especially, this means that enabling any other feature that has a proxy aspect will enable the proxy (like REX), if I am reading the code correctly.
Why are you introducing these changes? (Problem description, related links)
What are the changes introduced in this pull request?
How to test this pull request
Steps to reproduce:
Checklist