Warn about unrecognized smart proxy features#554
Draft
adamruzicka wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
adamruzicka
force-pushed
the
unknown-proxy-features
branch
from
540d0d5 to
a2f7446
Compare
Contributor
Author
This would require a test that would intentionally break things just to check that this would then emit a warning. I'm open to idea, but at this point I'm leaning towards not having tests for this here. |
ehelms
reviewed
Jun 15, 2026
| msg: >- | ||
| Proxy {{ foreman_proxy_name }} has features not recognized by Foreman: | ||
| {{ _foreman_proxy_registration.entity.smart_proxies[0].unrecognized_features | join(', ') }}. | ||
| If these features come from a Smart Proxy plugin, make sure Foreman has the plugin installed too. |
Member
There was a problem hiding this comment.
I don't think a user can act on this cleanly. Plugins are not a thing we expose here in foremanctl. We present the user with features. I like the general idea of where you are going with this, but it feels like a post_install check that should happen once at the end of deploy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to theforeman/foreman#11017
Why are you introducing these changes? (Problem description, related links)
Currently if the proxy offers more features than Foreman knows, those would go silently ignored (unless all of the proxy's features are unknown to Foreman), which makes it hard to spot misconfigured deployments.
What are the changes introduced in this pull request?
After registering a proxy, fctl will check if all the proxy's features are recognized by Foreman and warn if not.
How to test this pull request
Steps to reproduce:
Checklist