fix: preserve user-provided id in initialState instead of overwriting (#351)#352
Open
a-kriya wants to merge 2 commits intothefrontside:mainfrom
Open
fix: preserve user-provided id in initialState instead of overwriting (#351)#352a-kriya wants to merge 2 commits intothefrontside:mainfrom
a-kriya wants to merge 2 commits intothefrontside:mainfrom
Conversation
Member
|
Looks like it missed creating the preview package. I think #353 should fix it if you merge from the main branch. That should allow you to try it out in your project right away. |
a-kriya
force-pushed
the
user-id-override
branch
from
f6dbfc4 to
769cff3
Compare
Author
|
Rebased on main, and added a separate commit for the test refactor along with new tests to cover this bug. Feel free to modify things--I basically wanted to be able to run the tests without needing to install SSL certificate, so I made modifications to run the tests over http. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351
Motivation
To fix a bug where the user id provided in
initialStatewould get ignored.Approach
Similar to how the other fields are handled, the
idis now also conditionally set if it is not already provided.TODOs and Open Questions