Skip to content

Basic support for portgroups in network resource#46

Open
andersbs wants to merge 1 commit into
thias:masterfrom
andersbs:ovs_portgroups
Open

Basic support for portgroups in network resource#46
andersbs wants to merge 1 commit into
thias:masterfrom
andersbs:ovs_portgroups

Conversation

@andersbs

Copy link
Copy Markdown

Not a fan of passing in hashes but the alternative would be define libvirt::network::portgroup with concat fragments.

$networks = {
  'net-vl-50' => {
    autostart => true,
    bridge    => 'br0',
    forward_mode => 'bridge',
    virtualport => true,
    portgroups => {
      'port-vl-50' => {
        'default' => 'yes',
        vlan => [
          '50',
        ],
      },
    },
  },
  'net-vl-56' => {
    autostart => true,
    bridge    => 'br0',
    forward_mode => 'bridge',
    virtualport => true,
    portgroups => {
      'port-vl-56' => {
        'default' => 'yes',
        vlan => [
          '56',
        ],
      },
    },
  },
}

create_resources('::libvirt::network', $networks)

@igalic

igalic commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

@andersbs can you please extend the documentation, and maybe add a spec test

@andersbs

Copy link
Copy Markdown
Author

Will do. Just gotta get rspec-system into my system somehow. I've just learned about rspec and I'm using the puppetlabs-helper that the new puppet module generate uses.

@igalic

igalic commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

oh dear.
that's right. this module still uses rspec-system :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants