Repository navigation
fix: isolate Bun startup for external lanes - #50
Merged
Merged
Conversation
Project dotenv files, Bun preloads, and inherited startup options could run before the external lane runner checked routing and credentials. - Move the TypeScript entrypoint behind a shell launcher that clears BUN_OPTIONS and NODE_OPTIONS and disables automatic env/config loading. - Invoke the launcher directly from OMP and subprocess test helpers so the startup isolation also applies to cancellation and explicit deadlines. - Cover individual and combined startup inputs with synthetic fixtures, including exported credentials and child identity preservation. Refs #37. Ports the launcher isolation from open-pstack PR ericlitman#113.
thisguymartin
marked this pull request as ready for review
October 13, 2026 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
What changed
Project
.envfiles, Bun preloads, and inherited startup options could affect the external lane runner before its routing and credential checks. The launcher now clearsBUN_OPTIONSandNODE_OPTIONS, disables automatic env-file loading, and uses/dev/nullfor Bun configuration. Normal exported variables still reach the runner and its provider child.runner/entry.tsbehind the shell launcher.Ports the launcher isolation from open-pstack PR #113.
Verification
bash scripts/check.shpassed in an isolated checkout containing only this change: 269 tests passed, including the startup cases and existing explicit-deadline/cancellation tests. Bun 1.4.2.Live evidence:
A pull request without live evidence remains a draft. Do not merge, tag, release, or roll it out.