Added check to see if element is only being dragged horizontaly #80
+15,885
−9,298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
For layouts where there are horizontal as well as vertical scrolls, the pull down to refresh does not working properly as it assumes I am pulling down when I just want to scroll horizontally.
What was the problem, technically?
The problem was that when you start touch from lets say [0,0] to [-30,-10] you will be dragging more to the left side than down and don't want to trigger the pull to refresh for that.
What did I implement?
I made sure that I trigger pull to refresh while dragging only when the distance dragged vertically is more than distance dragged horizontally.
Demo
Before:
After:
