show search bar again#17
Open
muelli wants to merge 1 commit into
Open
Conversation
Somehow the map goes full screen and hides the search bar. This makes it slightly better, but it doesn't fully solve the problem, since there are some pixels overlapping. But at least the search can be used again.
Owner
|
True, maybe that's some change of leaflet's behaviour. 50px doesn't looks right to me, though. It looks like the bar is roughly 70px tall. Maybe you could set a fixed height for the top bar and then have the same value for the margin? Alternatively we could put both elements into a flexbox container and let the browser figure that one out. |
Contributor
Author
|
OpenLoveMap/static/css/main.css Line 38 in 3d519d7 3rem seems to be the definition. Changing #bigmap to 4rem makes it look reasonably nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow the map goes full screen and hides the search bar. This makes it slightly better, but it doesn't fully solve the problem, since there are some pixels overlapping. But at least the search can be used again.