[pull] master from jquast:master - #37
Merged
Merged
Conversation
Various changes and accommodations made for the protocols used by Discworld MUD server.
Preparing for next release, 5.0.0:
* bugfix: ``IAC SB IAC SE`` (sub-negotiation with no option byte) should not raise ``IndexError``
* new: :meth:`~telnetlib3.stream_writer.TelnetWriter.add_will_callback` and
:meth:`~telnetlib3.stream_writer.TelnetWriter.remove_will_callback` for per-option
callbacks invoked after :meth:`handle_will` negotiation. Replaces the previous
closure-wrapping pattern in :class:`~telnetlib3.client.TelnetClient` for GMCP, ZMP,
and CHARSET will-detection.
* changed: :meth:`~telnetlib3.stream_writer.TelnetWriter.handle_zmp` now receives
``command, *args`` instead of one ``parts`` list; ``zmp_data`` moved to
``writer.ctx`` and is now a dict keyed by command (was a list of messages). New
:meth:`~telnetlib3.stream_writer.TelnetWriter.send_zmp`.
* changed: MUD protocol subnegotiation data (``mssp_data``, ``atcp_data``,
``aardwolf_data``, ``mxp_data``, ``comport_data``) moved from
:class:`~telnetlib3.stream_writer.TelnetWriter` to
:class:`~telnetlib3._session_context.TelnetSessionContext` (``writer.ctx.mssp_data``,
etc.). Deprecated writer properties delegate to ``ctx``; ``writer.zmp_data`` is
removed without deprecation.
* changed: client-side MUD protocol declines (GMCP, MSDP, MSSP, MSP, MXP, ZMP,
AARDWOLF, ATCP) remain the default; the decline log messages now name the enable
mechanism (``always_will`` / ``always_do`` / ``passive_do``) used by downstream
clients such as telix to accept them. Note that MXP's negotiation direction is
server-sends-``DO`` (the LPMud family convention, e.g. Discworld), so a client
accepting MXP replies ``WILL`` to ``IAC DO MXP``.
* enhancement: ``telnetlib3-fingerprint`` now accepts all MUD protocol offers (ATCP,
AARDWOLF, MSP, MXP, MSDP, MSSP) to collect subnegotiation data.
* enhancement: sub-negotiation payloads are bounded to 1,000KB.
* enhancement: ``--loglevel=trace`` receive dumps show the decompressed telnet
stream (MCCP2, MCCP3) instead of raw compressed bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )