Fix invalid committer email in bump-native-deps workflow - #33
Closed
brionmario wants to merge 1 commit into
Closed
Conversation
The workflow committed as a fabricated thunderid[bot] identity with an invented users.noreply.thunderid.dev address, which the DCO check rejects as an invalid committer email. Switch to the real thunder-automation-bot account and its GitHub-issued noreply email, matching the identity that already opens the PR. Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR #32 (and every prior run of the
bump-native-depsworkflow) fails the DCO check with "Invalid committer email". The workflow commits as a fabricatedthunderid[bot]identity using an inventedusers.noreply.thunderid.devaddress, which isn't a real GitHub-verified email/domain, so DCO rejects it regardless of the existinggit commit -ssign-off.Approach
Switch
RELEASE_GIT_USER_NAME/RELEASE_GIT_USER_EMAILto the realthunder-automation-botaccount and its GitHub-issued noreply email (272109929+thunder-automation-bot@users.noreply.github.com). This also aligns the commit identity with the account that actually opens the PR (previously the commit author/committer and the PR author were different identities).Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks