Add ThunderID provider helper for Generic OAuth plugin - #90
Open
brionmario wants to merge 2 commits into
Open
Conversation
…ugin Adds @thunderid/better-auth, a community provider helper that returns a typed GenericOAuthConfig for a ThunderID issuer to use with Better Auth's generic-oauth plugin. All OAuth 2.0 / OIDC handling is performed by Better Auth itself; this package only supplies configuration, so there is no ThunderID SDK dependency or protocol logic to keep in sync. Related: thunder-id/thunderid#3559 Signed-off-by: Brion <info@brionmario.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brionmario
changed the title
brionmario
added a commit
to brionmario/better-auth
that referenced
this pull request
Sep 2, 2026
Adds ThunderID to the Community Provider Helpers table for the Generic OAuth plugin, per better-auth#11059. The @thunderid/better-auth package returns a typed GenericOAuthConfig for a ThunderID issuer; all OAuth 2.0 / OIDC handling is performed by Better Auth itself. Related: thunder-id/thunderid#3559 See: thunder-id/javascript-sdks#90 Signed-off-by: Brion <info@brionmario.com>
The Generic OAuth plugin's core callback route is /callback/:providerId, not /oauth2/callback/:providerId. Verified against a running sample app sign-in. Signed-off-by: Brion <info@brionmario.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@thunderid/better-auth, a community provider helper for Better Auth's Generic OAuth plugin.It returns a typed
GenericOAuthConfigfor a ThunderID issuer. All OAuth 2.0 / OIDC handling is performed by Better Auth itself — this package only supplies configuration, so there is no ThunderID SDK dependency and no protocol logic to keep in sync.This follows the approach requested by the Better Auth maintainers after better-auth/better-auth#10237 (a first-class
generic-oauthprovider export) was declined per their social provider integration policy — they asked for a community provider helper package instead, to be listed in their docs.What's included
thunderid()helper +ThunderIDOptionstype (src/thunderid.ts)src/__tests__/thunderid.test.ts)Checks
pnpm --filter @thunderid/better-auth run typecheck✅pnpm --filter @thunderid/better-auth run test✅ (6 passed)pnpm --filter @thunderid/better-auth run lint✅pnpm --filter @thunderid/better-auth run format:check✅Related: thunder-id/thunderid#3559