fix(#701): turn off telemetry by default on self-hosted instances#714
Open
rbalogic wants to merge 1 commit intothunderbird:mainfrom
Open
fix(#701): turn off telemetry by default on self-hosted instances#714rbalogic wants to merge 1 commit intothunderbird:mainfrom
rbalogic wants to merge 1 commit intothunderbird:mainfrom
Conversation
216ed9c to
909efc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data_collection) to off for self-hosted/OIDC deployments.true.Why?
Self-hosted deployments should be privacy-first by default. This aligns runtime behavior with the intended deployment mode semantics (
VITE_AUTH_MODE=oidc).Changes
src/defaults/settings.tsgetDefaultDataCollectionValue(authMode?: string)data_collectionsetting to use that helper.src/lib/posthog.tsxgetSettingsfallback fordata_collectionto use the helper.src/settings/preferences.tsxuseSettingsfallback fordata_collectionto use the helper.src/defaults/settings.test.tsoidc->falseconsumer->truetrueTest Plan
bun test src/defaults/settings.test.tsbun test src/lib/posthog.test.tsmake formatbun run checkRelated
Note
Medium Risk
Changes the default telemetry opt-in behavior based on
VITE_AUTH_MODE, which can affect analytics initialization and user-visible defaults across deployments. Low implementation complexity, but sensitive due to privacy/telemetry semantics.Overview
Telemetry (
data_collection) is now disabled by default when running inoidc(self-hosted/enterprise) mode, while remaining enabled by default for consumer/unspecified modes.This centralizes the mode-based default in
getDefaultDataCollectionValue()and updates all fallback/default paths (default settings seed, PostHog initialization, and Preferences settings hook) to use it, with a small unit test added to lock in the behavior.Reviewed by Cursor Bugbot for commit 909efc5. Bugbot is set up for automated code reviews on this repo. Configure here.