[WEB-4585, 4577, 4578] - Carb Modifications + Device Names + Deduplicate Healthkit

[henry-tp]

WEB-4585
WEB-4577
WEB-4578

[henry-tp]

Mirrors this change which was needed to get the correct device name:

https://github.com/tidepool-org/blip/pull/1851/changes#diff-db3e63408cd99b33752ad54ec85da7dfbc87f67c608673c6bcb42a653c65a1b2R896

[Copilot]

Pull request overview

Updates the export/report generation pipeline to support newer Tidepool Viz report behavior (carb modifications, device name metadata, and HealthKit deduplication) by upgrading @tidepool/viz and requesting additional metadata in report queries.

Changes:

• Bump @tidepool/viz from 1.53.0-rc.1 to 1.56.0 (and update yarn.lock accordingly).
• Request additional DataUtil metadata (devices, matchedDevices) in all report query definitions.
• Update report query expectations in test/report.test.js to match the new metadata request.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
package.json	Upgrades @tidepool/viz dependency to 1.56.0.
yarn.lock	Locks the upgraded @tidepool/viz@1.56.0 resolution and checksum.
lib/report.mjs	Expands metaData requested by report queries to include devices and matchedDevices.
test/report.test.js	Updates expected report query objects to include the expanded metaData string.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[henry-tp]

We need to allow Viz to run the code that detects and sets the excludedDevices by not forcing through this argument of [].

However, Viz will usually just use its fallback arg of []

[krystophv]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 81d33fca-5de1-442e-b59e-b946b442f1c5

📥 Commits

Reviewing files that changed from the base of the PR and between c94c243 and e06082b.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (3)

• lib/report.mjs
• package.json
• test/report.test.js

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved report generation so device information is included more reliably across several report views.
  • Fixed report query behavior to better support device alignment and matching in generated reports.
• Chores
  • Updated a reporting-related library to the latest release.

Walkthrough

In lib/report.mjs, the buildReportQueries method now requests devices, matchedDevices in metaData (previously only latestPumpUpload, bgSources) and removes excludedDevices: [] from query objects for all six report types. Tests are updated to match. @tidepool/viz is bumped from 1.53.0-rc.1 to 1.56.0.

Changes

Report Query metaData Expansion

Layer / File(s)	Summary
buildReportQueries and test updates lib/report.mjs, test/report.test.js, package.json	metaData expanded to include devices, matchedDevices and excludedDevices: [] removed for basics, bgLog, daily, agpBGM, agpCGM, and settings queries; tests updated to match; @tidepool/viz bumped to 1.56.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is specific and partially matches the device-related query changes, though some listed items are not reflected in the diff.
Description check	✅ Passed	The description is related because it links the pull request to the Jira issues for this change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch WEB-4578-carb-modifications

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

---

_{Comment @coderabbitai help to get the list of available commands.}