fix(istio): set platform=gke on istiod and ztunnel charts#4463
Open
electricjesus wants to merge 1 commit intomasterfrom
Open
fix(istio): set platform=gke on istiod and ztunnel charts#4463electricjesus wants to merge 1 commit intomasterfrom
electricjesus wants to merge 1 commit intomasterfrom
Conversation
The GKE platform was only being set on the CNI chart opts, leaving istiod and ztunnel without their GKE-specific profile configurations. This caused ztunnel to miss a ResourceQuota and istiod to have a blank PLATFORM env var instead of "gke". Set global.platform=gke on IstiodOpts and ZTunnelOpts alongside IstioCNIOpts, matching the pattern already used for OpenShift. Closes: EV-6377 Related: EV-6376
electricjesus
force-pushed
the
seth/fix-istio-gke-platform
branch
from
719a6cd to
9931f28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global.platformwas only being set togkeon the CNI chart, leaving istiod and ztunnel without GKE-specific profile configurationsplatform=gketoIstiodOpts.GlobalandZTunnelOpts.GlobalalongsideIstioCNIOpts.Global, matching the pattern used for OpenShift in fix(istio): Set platform=openshift for istio on OpenShift #4402PLATFORM=gkeon istiod's discovery containerTest plan
PLATFORM=gkeenv var on istiod discovery containergo test ./pkg/render/istio/passes (33/33 specs)Closes: EV-6377
Related: EV-6376, #4402