Split ServiceEndpoint into host-network and pod-network fields#4474
Open
coutinhop wants to merge 2 commits intotigera:masterfrom
Open
Split ServiceEndpoint into host-network and pod-network fields#4474coutinhop wants to merge 2 commits intotigera:masterfrom
coutinhop wants to merge 2 commits intotigera:masterfrom
Conversation
Rename Host/Port to HostNetworkHost/HostNetworkPort and add new PodNetworkHost/PodNetworkPort fields to ServiceEndpoint. This allows the operator to configure different K8s API server endpoints for host-networked vs pod-networked pods. For host-networked pods, EnvVars() uses HostNetworkHost/HostNetworkPort. For pod-networked pods, EnvVars() uses PodNetworkHost/PodNetworkPort. Both inject the standard KUBERNETES_SERVICE_HOST/PORT env var names. The pod-network values are read from the kubernetes-services-endpoint ConfigMap using the KUBERNETES_SERVICE_HOST_POD_NETWORK and KUBERNETES_SERVICE_PORT_POD_NETWORK keys. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
coutinhop
force-pushed
the
pedro-CORE-12314
branch
from
445c75d to
a24a266
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename Host/Port to HostNetworkHost/HostNetworkPort and add new PodNetworkHost/PodNetworkPort fields to ServiceEndpoint. This allows the operator to configure different K8s API server endpoints for host-networked vs pod-networked pods.
For host-networked pods, EnvVars() uses HostNetworkHost/HostNetworkPort. For pod-networked pods, EnvVars() uses PodNetworkHost/PodNetworkPort. Both inject the standard KUBERNETES_SERVICE_HOST/PORT env var names.
The pod-network values are read from the kubernetes-services-endpoint ConfigMap using the KUBERNETES_SERVICE_HOST_POD_NETWORK and KUBERNETES_SERVICE_PORT_POD_NETWORK keys.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.