Skip to content

CORE-12219: Add kubevirt.io RBAC to CNI plugin for KubeVirt IPAM#4477

Open
skoryk-oleksandr wants to merge 2 commits intotigera:masterfrom
skoryk-oleksandr:oleks-kubevirt-rbac-changes
Open

CORE-12219: Add kubevirt.io RBAC to CNI plugin for KubeVirt IPAM#4477
skoryk-oleksandr wants to merge 2 commits intotigera:masterfrom
skoryk-oleksandr:oleks-kubevirt-rbac-changes

Conversation

@skoryk-oleksandr
Copy link
Contributor

Description

CORE-12219: Add kubevirt.io RBAC to CNI plugin for KubeVirt IPAM

Release Note

TBD

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

APIGroups: []string{"kubevirt.io"},
Resources: []string{"virtualmachineinstances", "virtualmachines"},
Verbs: []string{"get"},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelljerram Have you added RBAC role for VMIM already or it should be included in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here in my PR - hopefully landing soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants