Add labels and annotations to TLS secrets for discoverability#4479
Open
rene-dekker wants to merge 1 commit intotigera:masterfrom
Open
Add labels and annotations to TLS secrets for discoverability#4479rene-dekker wants to merge 1 commit intotigera:masterfrom
rene-dekker wants to merge 1 commit intotigera:masterfrom
Conversation
rene-dekker
force-pushed
the
ev-6449
branch
2 times, most recently
from
c5b075a to
afae4f0
Compare
Surface certificate metadata (issuer, expiry, DNS SANs, IP SANs) and hash annotation on TLS secrets produced by Secret() and CreateSelfSignedSecret(). Add a signer label for filtering. Add unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface certificate metadata (issuer, expiry, DNS SANs, IP SANs) as annotations and add filtering labels (secret-type, signer) on TLS secrets produced by Secret() and CreateSelfSignedSecret().
This allows filtering secrets by secret type and /or issuer. It allows us to quickly see the signer, expiry and other metadata using describe, it can really speed up troubleshooting certificate misconfigurations and other issues.
This is now possible, which would be very helpful to our users: