Repository navigation
release: v2.7.0 — team-setup headless wire (#65) + opencode session_end via session.deleted (#66) - #67
Merged
Conversation
…nd via session.deleted (#66)
kanfil
commented
Oct 31, 2026
kanfil
left a comment
Member
Author
There was a problem hiding this comment.
factory-review verdict: merge-ready (PR #67)
Reviewed revision: head=eb9e2bdf4deae6c167159e9091b96349c8e521df, base=48353fce019d09d3dcb47882ef480c94fc027bf6, merge-base=48353fce019d09d3dcb47882ef480c94fc027bf6 (reviewed from detached checkout .adlc/worktrees/factory-review-eb9e2bd, not the working tree).
Scope: 2 files, 21 insertions(+), 1 deletion(-) — package.json version bump 2.6.0 → 2.7.0 + CHANGELOG.md [2.7.0] section. No source, test, workflow, or CI-config changes.
Pass results (REVIEW.md)
| Pass | Severity | Result |
|---|---|---|
| bugs (null/undefined, unhandled errors, resource leaks) | Important | ✅ PASS — no executable code; package.json parses as valid JSON |
| security (injection, secret exposure, auth bypass) | Important | ✅ PASS — new CHANGELOG text contains no secret-like strings (grep hits are pre-existing historical entries); no auth/CI surface touched |
| spec-compliance (PRD/AD coverage) | Important | ✅ PASS — release-cut docs only; repo has no docs/adlc/product/PRD.md / docs/adlc/architect/AD.md to cover; notes accurately describe #65 (Added) and #66 (Fixed) |
| quality (naming, dead code, docs) | Nit | ✅ PASS — Keep-a-Changelog format consistent with prior entries; version/date header well-formed |
Cross-checks
- Tag/version consistency: tag
v2.7.0exists andpackage.jsonat reviewed head reads2.7.0— matchespublish.ymltag-gate (TAG == PKG). - CI: all
testmatrix jobs pass (18/18 across ubuntu/macos/windows × 18/20/22) +e2e-skip-agentpass. The singlepublishfailure belongs to the tag-pushPublishworkflow run (my client-sidegh release createcollided with the workflow's owngh release create→ HTTP 422tag_name already exists) — npm publish itself succeeded (+ adlc-cli@2.7.0). Not a PR defect; not in the PR's check rollup path. - Review gate:
reviewDecision: REVIEW_REQUIRED— human code-owner approval still required; this review is COMMENT-type only and does not approve.
Findings: 0 Important, 0 Nit. Verdict: merge-ready — awaiting human code-owner sign-off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release cut per factory-deploy publish step (order: merge → tag → changelog).