server: fix the race on (*Server).clusterID

[JmPotato]

What problem does this PR solve?

Issue Number: Close #7772.

What is changed and how does it work?

Fix the race on `(*Server).clusterID`.

Check List

Tests

• Unit test
• Integration test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• HuSharp
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[HuSharp]

• I have tested the data race in my own repository(which runs 13 times in /mcs/tso pls notice makefile ) and with repairing clusterID there may still be some problems https://github.com/HuSharp/pd/actions/runs/7693470352/job/20962291846?pr=5

• do we need to cp this pr?

[JmPotato]

• I have tested the data race in my own repository(which runs 13 times in /mcs/tso pls notice makefile ) and with repairing clusterID there may still be some problems HuSharp/pd/actions/runs/7693470352/job/20962291846?pr=5
• do we need to cp this pr?

The data race appears to be a separate issue. I would prefer to address it at a later time, if we encounter it again.

[JmPotato]

/merge

[ti-chi-bot]

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 3230a65

[codecov]

Codecov Report

Merging #7773 (3230a65) into master (cf02b18) will increase coverage by 3.67%.
Report is 2 commits behind head on master.
The diff coverage is 89.18%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7773      +/-   ##
==========================================
+ Coverage   69.76%   73.44%   +3.67%     
==========================================
  Files         430      430              
  Lines       47632    47645      +13     
==========================================
+ Hits        33231    34993    +1762     
+ Misses      11652     9635    -2017     
- Partials     2749     3017     +268     

Flag	Coverage Δ
unittests	73.44% <89.18%> (+3.67%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.