Skip to content

[Docs] RoPE gets its own Benchmarks page, after Elementwise - #44

Merged
lcy-seso merged 1 commit into
tile-ai:mainfrom
lcy-seso:docs/bench-family-fixes
Sep 4, 2026
Merged

[Docs] RoPE gets its own Benchmarks page, after Elementwise#44
lcy-seso merged 1 commit into
tile-ai:mainfrom
lcy-seso:docs/bench-family-fixes

Conversation

@lcy-seso

@lcy-seso lcy-seso commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Problems

  • Positional encoding sat in Other next to FFT, MHC and Top-k, which is where a family goes when it is too small to carry a page. Six ops and 13 workloads is not that.
  • Other therefore read as a page about RoPE with three other families appended.

Changes

  • New rope data page, titled RoPE to match the API reference's nav label for the same ops. Page order: Elementwise, RoPE, Reduction, Normalization, Conv & Pool, GEMM, Quantization, Attention, MoE, Linear Attention, SSM, Other.
  • FAMILY_TITLE["positional"] is now RoPE.
  • Other holds FFT, MHC, Top-k and Scan.
  • hooks.py lists rope.md in nav order. mkdocs.yml needs no change: nav_translations already carries RoPE.

Rendered against the newest snapshot (182 ops, 1063 workloads):

Page Ops Workloads
Elementwise 70 404
RoPE 6 13
Reduction 21 90
Normalization 10 69
Conv & Pool 16 108
GEMM 7 67
Quantization 2 4
Attention 13 79
MoE 9 52
Linear Attention 17 131
SSM 7 35
Other 4 11

The fixture snapshot declares no positional op, so tests/golden/ is unchanged. Seven tests, unchanged in number.

Not changed

The vector norms (L1NormFwd, L2NormFwd, InfNormFwd), the logical reductions (AllFwd, AnyFwd) and the softmax family stay on the Reduction page. All of them are exported as tileops.reduction.<Op> and subclass the reduction base, and PyTorch lists all, any and norm under Reduction Ops while ONNX names the vector norms ReduceL1 and ReduceL2. Softmax is the one op PyTorch files elsewhere — torch/nn/modules/activation.py, not normalization.py — but there is no activation family here, and a row-wise op does not belong on the Elementwise page.

Positional encoding sat in `Other` alongside FFT, MHC and Top-k. Six ops and 13
workloads is enough to carry a page, and the rotation is applied to one tensor
in place, so the page goes right after Elementwise: `Elementwise`, `RoPE`,
`Reduction`, `Normalization`, `Conv & Pool`, `GEMM`, `Quantization`,
`Attention`, `MoE`, `Linear Attention`, `SSM`, `Other`.

The family is titled `RoPE`, matching the API reference's nav label for the
same ops. `Other` now holds FFT, MHC, Top-k and Scan — 4 ops, 11 workloads.
Copilot AI lite review requested due to automatic review settings September 4, 2026 01:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The updates are consistent across the renderer and MkDocs nav hook, and the new page is only included when actually generated (present on disk).

Pull request overview

This PR refactors the Benchmarks section’s generated page grouping so RoPE (previously under the positional family) is promoted from the “Other” page into its own dedicated data page, keeping Benchmarks navigation aligned with the API reference’s RoPE labeling.

Changes:

  • Renamed the positional family title to RoPE and added a new rope data page that contains the positional family.
  • Removed positional from the “Other” Benchmarks page’s family list so “Other” now holds FFT/MHC/Top-k/Scan (+ truly “other”).
  • Updated the MkDocs hook Benchmarks nav ordering to place rope.md immediately after elementwise.md.
File summaries
File Description
scripts/gen_bench_pages.py Introduces the new rope Benchmarks data page and moves the positional family out of “Other”.
hooks.py Inserts rope.md into the Benchmarks navigation order after elementwise.md.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lcy-seso
lcy-seso merged commit ae92b83 into tile-ai:main Sep 4, 2026
3 checks passed
@lcy-seso
lcy-seso deleted the docs/bench-family-fixes branch September 4, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants