[Docs] Follow the upstream op list: drop the packed GQA prefill op, add FusedTopKOp - #45
Merged
lcy-seso merged 1 commit intoSep 5, 2026
Conversation
…dd FusedTopKOp The daily refresh checks TileOPs out fresh, so an op that leaves `__all__` upstream breaks the build the next morning. tile-ai/TileOPs#2058 removed `GroupedQueryAttentionPrefillFwdOp`, and mkdocstrings aborted with "Could not collect 'tileops.attention.GroupedQueryAttentionPrefillFwdOp'". `tileops.moe.FusedTopKOp` is exported upstream and was never on the MoE page. It runs before the permutation, so it goes first under Routing and layout. Every mkdocstrings entry under docs/api/ now matches the `__all__` of its upstream module, with no entry missing and none left over.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized doc directive updates that remove a known-broken reference and add the missing upstream-exported op entry.
Pull request overview
Updates the API reference wrappers under docs/api/ to match the current upstream TileOPs exported operator list, unblocking mkdocstrings builds and ensuring the MoE API page includes the newly exported routing op.
Changes:
- Removed the stale
tileops.attention.GroupedQueryAttentionPrefillFwdOpmkdocstrings entry that was breaking the daily refresh/build. - Added
tileops.moe.FusedTopKOpunder “Routing and layout” and updated the MoE intro paragraph to reflect the routing stage.
File summaries
| File | Description |
|---|---|
| docs/api/moe.md | Adds FusedTopKOp documentation and updates the page narrative to include expert-picking as a first-stage op. |
| docs/api/attention.md | Drops the removed upstream prefill op entry so mkdocstrings no longer tries to import a non-existent symbol. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problems
GroupedQueryAttentionPrefillFwdOp: mkdocstrings aborts with "Could not collect 'tileops.attention.GroupedQueryAttentionPrefillFwdOp'" (run 33930934575).tileops.moe.FusedTopKOpis exported upstream and has no entry on the MoE page.changes
GroupedQueryAttentionPrefillFwdOpentry fromdocs/api/attention.md.FusedTopKOptodocs/api/moe.md, first under Routing and layout, since it picks each token's experts before the permutation runs; the intro paragraph lists that stage too.docs/api/now matches the__all__of its upstream module, with no entry missing and none left over.mkdocs buildagainst a freshupstream/maincheckout of TileOPs: 0 errors, no warning outside griffe.pytest: 7 passed.