fix(deps): pin basic-ftp to patched 5.3.1#2
Open
time-attack wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fresh gstack installs now resolve
basic-ftp5.3.1 instead of vulnerable 5.2.0. This removes four HIGH-severitybasic-ftpfindings from the installed dependency tree.How it works
The root package adds a Bun override for
basic-ftp5.3.1. Regenerating the lockfile updates the single transitive resolution and integrity hash, so all paths throughget-uriand the browser dependency tree load the patched release.What was broken
Fresh gstack installs loaded
basic-ftp5.2.0. GitHub's advisory database reports four HIGH advisories affecting that release, including a denial-of-service issue whose first patched version is 5.3.1.How it was fixed
I added the root override, regenerated
bun.lock, and added a focused regression test. The test checks both the declared override and everybasic-ftpversion in the lockfile so a vulnerable nested resolution cannot silently return.Live evidence
The pr-test-env harness used immutable
origin/mainat7c9df1c568a9and separate baseline/candidate directories and HOME roots. The same installed-runtime command was replayed in every candidate environment.Gate result: PASS, five fail-to-pass reproductions, identical command hash
7b0b236926603b25e947019e55b3f4e3d9bac6f13b546018230b330e70efa868.bun audit --jsonlisted these findings on baseline and none forbasic-ftpon candidate:Runtime smoke:
runtime basic-ftp=5.3.1 client=Client.Secondary checks
bun test test/basic-ftp-security-pin.test.ts— passbun run build— pass; existing non-fatal Factory token-ceiling warning remainsgit diff --check— passScope and remaining risk
This proves patched dependency selection and runtime loading, not a live exploit replay against a malicious FTP server. Unrelated audit findings are intentionally outside this patch. No
VERSION, package version, orCHANGELOG.mdchanges are included.