fix(codex): preserve search mode and harden Codex workflows#5
Open
time-attack wants to merge 4 commits into
Open
fix(codex): preserve search mode and harden Codex workflows#5time-attack wants to merge 4 commits into
time-attack wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Keeps Codex web search working without deprecated flags or silently forcing live browsing, resolves make-pdf correctly from Codex installs, avoids an eval-based path lookup, and validates fenced bash in generated skills.
How it works
Codex invocations now inherit the user's configured web-search mode (cached by default), global browse resolution checks current Codex/agents locations before legacy Claude and PATH locations,
gstack-paths --getreturns one validated root, and a test runsbash -nover discovered fenced shell snippets.What was broken
gstack passed a deprecated cached-search feature toggle. The proposed
--searchreplacement would have changed cached search to live search. make-pdf could skip the active Codex browse installation,/codexneeded to evaluate assignment output to obtain paths, and an unclosed bash fence could ship undetected.How it was fixed
Removed the deprecated search toggle without adding
--search; added Codex/agents global resolution and executable-file validation; added strict scalar path lookup and updated the generated/codexskill; closed the bad fence and added bounded nested syntax coverage. Release/version files are untouched.Live evidence
23 -> 0; Cal.com and Plane remained0 -> 0controls. Identical-command gate PASS.1 -> 0; Cal.com and Stagehand remained0 -> 0controls. Identical-command gate PASS.--search-means-live semantics.Secondary verification
bun run build— PASS (existing generated ship-skill token-ceiling warnings only)git diff --check— PASSFull local review accounting and dossiers remain intentionally uncommitted under
.review/wave-codex-model/.