fix: reconstruct the setup/install safety wave#7
Open
time-attack wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconstructs the setup/install cleanup wave from the immutable upstream base
7c9df1c568a9ea745508f679a329332b2c338063. The old wave branch was not merged or cherry-picked; each retained problem was independently reimplemented as an atomic commit.This PR intentionally does not modify
VERSION, package version,CHANGELOG.md, ETHOS, or workflows. Each accepted problem remains a separate commit for selective review.Attribution
Accepted or partially reconstructed from PRs garrytan#902, garrytan#1143, garrytan#1219, garrytan#1469, garrytan#1580, garrytan#1727, garrytan#1813, garrytan#1845, garrytan#1900, garrytan#1932, garrytan#2119, garrytan#2148, garrytan#2208, garrytan#2225, garrytan#2232, garrytan#2233, and garrytan#2239. Competing fixes were compared by behavior rather than file overlap; unsafe and overbroad hunks were excluded.
Live verification
Seven isolated
pr-test-envcampaigns passed. Each used three real consumer repositories that failed on immutableorigin/mainand passed on this candidate, plus two unchanged controls using the identical probe:ls-remoteand real Git pushAdditional evidence:
bun run build: passed on the final head.git diff --check origin/main..HEAD: passed.Known boundary
Native Windows was unavailable. The Windows-safe aggregate runner reached shard 5 and then hit an unrelated pre-existing terminal-agent source-string assertion (
spawnClaudeversusmaybeSpawnPty); no file in this PR touches that component.The installed Conductor settings currently demonstrate why automatic migration is unsafe: implicit and explicit historical hook registrations use the same ownership tag. This PR prevents new implicit registrations but does not silently remove existing user settings.
Base and package
7c9df1c568a9ea745508f679a329332b2c33806387b0600fb3461f2c450af192bb339128dc1b4c69The fork's
mainis five commits ahead of the reviewed upstream base. A local merge-tree simulation completed without conflict; README was the only path changed on both sides.