Merged
Conversation
Contributor
Author
|
As for the CI failing, seems like error messages got updated. Want me to include a commit to fix them? |
Member
|
That one CI check has been failing for a little while now due to rust-lang/rust#119273. Delegating alignment to what it is for i128 is definitely the smart thing to do. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is failing on latest rust nightly (since rust-lang/rust#116672) and in
rustc_codegen_gccin the sync we're currently doing. Instead of having cfg, simpler to compare withu128type alignment directly, like that it will work in both nightly and the current version.