Conversation
…ow-org#182) self.D was never actually computed from this commented-out line - AquiferData.initialize() already computes it correctly as self.T / self.Scoefaq (Scoefaq = Saq * Haq), which is what's used elsewhere (e.g. the eigenvalue computation). The leftover comment in __init__ used self.T / self.Saq directly, which is dimensionally wrong (Saq is specific storage [1/L], not the dimensionless/areal storage coefficient) and would also fail at runtime since self.T isn't set yet at that point in __init__. Dead code, so removing it has no functional effect - verified a model still builds, solves, and reports the same aq.D as before. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #182