Repository navigation
Move the frontend to @clerk/react (Clerk Core 3) - #116
Open
jayypatel18 wants to merge 1 commit into
Open
jayypatel18 wants to merge 1 commit into
jayypatel18 wants to merge 1 commit into
Conversation
|
@jayypatel18 is attempting to deploy a commit to the tholmes' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi Tim, A gentle follow up on this PR. It upgrades your clerk package to the latest supported package before EOL Jan, 2027 of current package. Once you get time kindly take a look at this PR, your time is much appreciated! Thanks, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API side already uses
@clerk/backend3, but the frontend is still on@clerk/clerk-react5, which is the Clerk Core 2 package. Clerk renamed it to@clerk/reactin Core 3, and their schedule ends long term support for Core 2 in January 2027. This brings the frontend onto the same generation as the API.What changed
package.json,pnpm-lock.yaml:@clerk/clerk-react^5.61.9replaced by@clerk/react^6.0.0(resolves to 6.17.4).src/app/main.tsx: the dynamic import now loads@clerk/react. OnClerkProvider,afterSignInUrlandafterSignUpUrlwere removed in Core 3; they becomesignInFallbackRedirectUrlandsignUpFallbackRedirectUrl, same/#/value.src/features/auth/AccountButton.tsx,AuthBridge.tsx,UpgradeModal.tsx: import path only.src/features/auth/clerkAppearance.ts: Core 3 renamed five appearance variables.colorTextis nowcolorForeground,colorTextSecondaryiscolorMutedForeground,colorInputTextiscolorInputForeground,colorInputBackgroundiscolorInput,colorTextOnPrimaryBackgroundiscolorPrimaryForeground. Values are unchanged. Without this the sign-in modal would stop picking up the app's theme tokens, and TypeScript would not complain because the object is not typed asAppearance.What I checked
In a clean Node 22 container with pnpm 11, on
mainand then on this branch, with install scripts off. These are the steps inci.yml:pnpm install --frozen-lockfilepnpm testpnpm run typecheck(non-blocking in CI)pnpm run build:localNone of the 64 existing type errors are in files this PR touches (they are in the dashboard, media, weather, settings and RSS code).
Not checked: I did not sign in against a real Clerk instance, so the themed sign-in modal is the thing to eyeball. Nothing under
.agents/was touched.