Skip to content

Take reference for Real::min/Real::max #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timschmidt merged 1 commit into from
May 27, 2026
+4 −4
Merged

Take reference for Real::min/Real::max #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/real/arithmetic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,8 +1161,8 @@ impl Real {
/// If refinement cannot decide the order at the standard partial-order
/// precision, this keeps `self`, matching the conservative behavior of
/// [`PartialOrd`] callers that treat incomparability as no improvement.
pub fn min(self, other: Real) -> Real {
match self.partial_cmp(&other) {
pub fn min<'r>(&'r self, other: &'r Real) -> &'r Real {
match self.partial_cmp(other) {
Some(Ordering::Greater) => other,
_ => self,
}
Expand All @@ -1173,8 +1173,8 @@ impl Real {
/// If refinement cannot decide the order at the standard partial-order
/// precision, this keeps `self`, matching the conservative behavior of
/// [`PartialOrd`] callers that treat incomparability as no improvement.
pub fn max(self, other: Real) -> Real {
match self.partial_cmp(&other) {
pub fn max<'r>(&'r self, other: &'r Real) -> &'r Real {
match self.partial_cmp(other) {
Some(Ordering::Less) => other,
_ => self,
}
Expand Down
Loading