Add approx_rational for rational approximations of Computables#11
Open
TimTheBig wants to merge 4 commits into
Open
Add approx_rational for rational approximations of Computables#11TimTheBig wants to merge 4 commits into
approx_rational for rational approximations of Computables#11TimTheBig wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the approx_rational method to Computable in src/computable/node.rs, which provides a dyadic rational approximation within a specified precision. It includes a fast-path optimization for exact-rational leaves with power-of-two denominators and adds comprehensive unit tests. The feedback suggests simplifying the fast-path check by reusing the existing dyadic_denominator_shift method on Rational to improve code maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.