ci: generate SBOM and include it in the wheel#82
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pyproject.toml">
<violation number="1" location="pyproject.toml:7">
P2: `sbom-files` requires a newer hatchling, but `build-system.requires` does not set a minimum version. Add a lower bound (>=1.28.0) to avoid build-time config failures in environments that resolve older hatchling versions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This commit adds machinery to generate a CycloneDX SBOM file during the release flow. This file is automatically included in the built wheel by hatchling as specified in PEP 770. There is a placeholder SBOM file in the root directory to satisfy hatchling when building outside the release flow.
0880b1a to
50fb7b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds machinery to generate a CycloneDX SBOM file during the release flow. This file is automatically included in the built wheel by hatchling as specified in PEP 770. There is a placeholder SBOM file in the root directory to satisfy hatchling when building outside the release flow.
Summary by cubic
Generates a CycloneDX SBOM during the release flow and bundles it into the wheel per PEP 770. Adds CI steps and
hatchlingconfig, with a placeholder SBOM for non-release builds.Generate SBOMjob in.github/workflows/sdk-release.ymlusinguv/uvxandcyclonedx-bom==7.3.0to createsbom.cdx.json.pyproject.tomlsetssbom-files = ["sbom.cdx.json"]and requireshatchling>=1.28.0so the wheel includes the SBOM (PEP 770).sbom.cdx.jsonto keep local and non-release builds working.Written for commit 50fb7b1. Summary will update on new commits.