rootio: fix GPT partition index and sector alignment in Partition() - #216
Open
shcherbak wants to merge 1 commit into
Open
rootio: fix GPT partition index and sector alignment in Partition()#216shcherbak wants to merge 1 commit into
shcherbak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related bugs in
rootio/storage/partition.go'sPartition()(GPT path) that together makerootio partitionsilently produce a broken or misaligned partition table:gpt.Partition.Indexis never set.go-diskfs'sgpt.Partitionrequires a 1-basedIndexinto its 128-entryGPT array (see
table.toBytes()ingo-diskfs). Fix: setIndex: d.Partitions[x].Numberwhen building eachgpt.Partition.sectorEnd + 1, i.e. the very next 512-byte sector after the previous partition's end, with no regard for the underlying physical/logical sector size. On disks with 4Kn or 512e physical sectors (e.g. many enterprise/RAID controllers such as PERC/megaraid, which is what we hit this on) this produces partitions that don't start on a physical sector boundary, whichfdisk/partedflag (Partition N does not start on physical sector boundary) and which can hurt performance or, on some controllers, cause issues with subsequent tooling that assumes conventional alignment. Fix: add analignUp()helper that rounds a sector number up to the next 2048-sector (1MiB) boundary