Skip to content

feat(oidc): allow trusted clients to skip consent - #1158

Closed
tilwegener wants to merge 4 commits into
tinyauthapp:mainfrom
tilwegener:feat/trusted-oidc
Closed

tilwegener wants to merge 4 commits into
tinyauthapp:mainfrom
tilwegener:feat/trusted-oidc

Conversation

@tilwegener

@tilwegener tilwegener commented Sep 24, 2026 •

Copy link
Copy Markdown

Summary

  • add a trusted option for OIDC clients
  • skip the consent screen for trusted clients
  • support TINYAUTH_OIDC_CLIENTS_[NAME]_TRUSTED

Summary by CodeRabbit

  • New Features
    • Trusted OIDC clients can proceed without a consent screen, including when the user has not previously granted consent.
    • LDAP group searches now use a configurable filter, allowing group membership lookups to match different directory setups. The example configuration documents the username and user-DN placeholders used in search filters.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: tinyauthapp/tinyauth/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: baa4d6e0-ab97-42cb-89d6-c16b9349853d

📥 Commits

Reviewing files that changed from the base of the PR and between 4341445 and d25dacc.

📒 Files selected for processing (6)
  • .env.example
  • internal/controller/oidc_controller.go
  • internal/controller/oidc_controller_test.go
  • internal/model/config.go
  • internal/service/ldap_service.go
  • internal/test/test.go
 _____________________________
< Goodbye, code review angst. >
 -----------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tilwegener tilwegener closed this Sep 24, 2026
@tilwegener
tilwegener deleted the feat/trusted-oidc branch September 24, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant