gen-device: only generate device files for supported devices#5456
Conversation
This changes the make gen-device command such that it only converts relevant device files. This saves a lot of build time. The process of determining which files to convert is now handled by make. Incremental builds are now supported. Appropriate parallel building is now done for all device generation (previously it was only handled properly for AVR). The generated file names were updated to match their source name formatting. I could probbably lowercase everything when converting them, but this would complicate the makefile. I don't really think this is worth it.
|
Before: After: This is much faster and it reduces the storage used by device files by 86%. |
| } | ||
|
|
||
| func formatText(text string) string { | ||
| text = regexp.MustCompile(`[ \t\n]+`).ReplaceAllString(text, " ") // Collapse whitespace (like in HTML) |
There was a problem hiding this comment.
Might not be in scope of this actual PR but I stumbled across this some time ago - this regex is unnecessarily compiled multiple times
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
Seems reasonable, although I'll leave it to someone who actually deals with this files for the final word.
I think we should probably preserve the lowercase file names if we can to avoid case issues on OS like Windows. |
I am not entirely sure what you mean by this. I understand that Windows is case-insensitive, but we are just matching the source case here? |
4 participants
This changes the make gen-device command such that it only converts relevant device files. This saves a lot of build time.
The process of determining which files to convert is now handled by make. Incremental builds are now supported.
Appropriate parallel building is now done for all device generation (previously it was only handled properly for AVR).
The generated file names were updated to match their source name formatting. I could probbably lowercase everything when converting them, but this would complicate the makefile. I don't really think this is worth it.