require ProgramInfo for Ops.PROGRAM rooted asts - #18129
Open
Qazalin wants to merge 11 commits into
Open
Conversation
Qazalin
changed the title
Contributor
Changes |
Qazalin
marked this pull request as ready for review
September 11, 2026 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this might be why llama on master didn't converge. HCQ uses the ins/outs from ProgramInfo to graph the deps.
Without ProgramInfo, test_custom_kernel_source_copy fails correctness check on AMD and NV. METAL and CPU pass since they don't use another copy queue.