Conversation
Update the pinned commit for the vendored tinyagents dependency to incorporate upstream fixes or improvements. Auto-committed-on: macbook
Updated the pinned commit of the tinyagents submodule to incorporate upstream fixes and improvements. Auto-committed-on: macbook
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe ChangesTinyagents Reference Update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated dependency advances from the existing pin, and its changed tool-call argument format is accepted by the downstream parser. No merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
A rabbit checks the pointer's place Comment |
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Summary
vendor/tinyagentstoc1034c50, the merge commit of fix(discover): declare tool_call.arguments as a JSON string so constrained providers stop emptying it tinyagents#209. That PR declares thetool_callbridge'sargumentsas a JSON-encoded string, so schema-constrained providers stop answering it with{}.tool_search. In the reported case that wasGMAIL_SEND_EMAILfor theapple_stock_daily_emailcron job.main.Problem
On
openrouter/deepseek/deepseek-v4-flash-0731, the OpenRouter provider Sail Research returned everytool_callas nativetool_callswith"arguments": "{}". That droppednameas well as the arguments. The capture proxy (scripts/debug/capture-first-inference.mjs, with response bodies recorded) showed this happens before any OpenHuman parsing. It is not the DSML text parser that #6582 addresses:response_to_model_responseonly text-parses whentool_callsis empty.Solution
The fix is upstream, where the bridge lives. Replaying the captured request on the same route, by
argumentsschema:{"type":"object"}: 0 of 3 intactThe open object is rewritten or stripped by the strict, conservative and Gemini schema projections, so tinyagents#209 uses a string.
unwrap_tool_callalready accepts both a string and an object.Submission Checklist
Impact
tool_search→tool_call, on any provider that constrains decoding to the tool schema.maincommits between the current pin (157186cd) and the [Feature] E2E: MemoryDebugPanel settings interaction #209 merge, including tinyagents#207 (turn transcript ordering). It does not include [Feature] Add bulk namespace clear operation for memory #205, the DSML parser bump that Bump TinyAgents for TinyTools parser fixes #6582 carries. This overlaps with Bump TinyAgents for TinyTools parser fixes #6582, which moves the same gitlink; whichever merges second rebases onto the other.Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
tool-call-open-argsbba5fd94d3(tinyagents pinc1034c50)Validation Run
pnpm --filter openhuman-app format:check: N/A (no frontend changes)pnpm typecheck: N/Acargo test -p openhuman --lib agent::tinyagents::: 410 passed.cargo test -p openhuman --lib agent::: 2169 passed, 2 failed. The two failures,every_prompt_names_at_least_one_tool_it_can_callandthe_withheld_block_renders_for_a_renamed_session_with_a_filter, fail identically on the currentmainpin.cargo build -p openhuman-cli --bin openhuman-coreandcargo check --manifest-path crates/openhuman-app/Cargo.tomlsucceed against the merge-commit pin. Theagent::results above were rerun on it and are unchanged.End to end: a build with the pre-merge #209 head (
dbb72464, identical harness change) ran the realapple_stock_daily_emailjob on a copy of the affected user's data, on the same Sail Research route, captured through the proxy. The run had the #6585 behaviour simulated by removing unthreaded transcripts.tool_call {name: "GMAIL_SEND_EMAIL", arguments: "{body, is_html, recipient_email, subject, user_id}"}.Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
tool_callbridge advertisesargumentsas a JSON string.tool_searchcan be invoked on constrained-decoding providers.Parity Contract
argumentsis still accepted byunwrap_tool_call.Duplicate / Superseded PR Handling
Summary by CodeRabbit