Skip to content

chore(deps): bump vendored tinytools for the DSML tool_call tag fix - #196

Merged
senamakel merged 5 commits into
mainfrom
dsml-tool-call-tag
Sep 22, 2026
Merged

senamakel merged 5 commits into
mainfrom
dsml-tool-call-tag

Conversation

@senamakel

@senamakel senamakel commented Sep 22, 2026

Copy link
Copy Markdown
Member

Gitlink bump for tinyhumansai/tinytools#21.

invoke_xml already accepted DeepSeek's DSML prefix on <invoke>; the tagged-JSON grammar did not accept it on the tool_call tag family, so

<|DSML|tool_call>{"name": …, "arguments": {…}}</|DSML|tool_call>

parsed as narrative and the call was dropped with no error. Seen live from deepseek-v4-flash driving the code dialect in OpenHuman: the turn ended with the model's lead-in and the tool never ran.

Merge order: tinytools#21 first, then this. The gitlink points at that PR's branch head; I will repoint it to the merge commit on main before this merges.

Note for the consumer side: openhuman main currently pins a tinyagents commit (3c9ba00) that is not on main here, so the bump openhuman actually consumes lives on dsml-tool-call-tag-v2 (that commit + this bump). This PR is the main-based version of the same one-line change; whichever lands first, the other rebases onto it.

cargo test -p tinytools-agent on the pinned commit: 310 passed, 0 failed.

Co-authored-by: Medulla medulla@tinyhumans.ai

@tinysweeper

tinysweeper Bot commented Sep 22, 2026

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 28760a45c22f
Updated: 1790100895 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors
  • Spend: $0.000000
  • Tokens: 0 input · 0 output · 0 cached · 25 embedding
Head State Pass summary
914f8202c4f6 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790097984)
28760a45c22f ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790098156)
28760a45c22f ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790100895)

tinysweeper 0.1.0

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-22T17:30:16.440112Z 914f820 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 12 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 71bcb6b2-129b-42b2-a63c-68ab284f3336

📥 Commits

Reviewing files that changed from the base of the PR and between 5bbfcc5 and 28760a4.

📒 Files selected for processing (1)
  • vendor/tinytools

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 25 embedded · ladder/vectors

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 22, 2026
senamakel and others added 5 commits September 22, 2026 20:27
Picks up tinyhumansai/tinytools#21: the tagged-JSON grammar now accepts
DeepSeek's DSML marker and fullwidth pipes on the `tool_call` tag family,
the way `invoke_xml` already did for `<invoke>`. Without it a
`<|DSML|tool_call>` block parsed as narrative and the call was dropped
silently — seen live from `deepseek-v4-flash` on the code dialect.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The checkpoint hook swept a local `wiki` checkout into this branch. The
pin is unrelated to the tinytools bump, so put it back where main has it.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updated the wiki submodule to point to a newer commit, incorporating the latest changes from the upstream repository.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updated the wiki submodule to point to a newer commit, incorporating the latest changes from the upstream repository.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel merged commit 8582277 into main Sep 22, 2026
10 checks passed
senamakel added a commit to tinyhumansai/openhuman that referenced this pull request Sep 22, 2026
Same base main already pins (3c9ba00, the session-todo-list work this
tree depends on), plus the tinytools bump from tinyhumansai/tinyagents#196tinyhumansai/tinytools#21: a `<|DSML|tool_call>` block parsed as
narrative and the call was dropped silently. `deepseek-v4-flash` emits
that form on the code dialect, which is the path this branch's
integration work now leans on.

Repoint to the merge commit once #196 lands.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel deleted the dsml-tool-call-tag branch September 23, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant