Skip to content

Conversation

@kemister85
Copy link
Contributor

@kemister85 kemister85 commented Apr 3, 2025

Ticket: DOC-3194

Site: Staging branch

Changes:

  • update demo to reflect tinymce/latest demo, removal of authorImage as its not supported.
  • Removepollyjs.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested review from a team, Skylite73, jscasca, shanmen-tiny and tiny-ben-tran and removed request for a team April 3, 2025 11:01
@kemister85 kemister85 requested review from a team and HAFRMO as code owners April 3, 2025 11:01
author: uid,
authorName: uid,
};
}

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (95% of all statements in
the enclosing script
have an explicit semicolon).

Copilot Autofix

AI 9 months ago

To fix the problem, we need to add an explicit semicolon at the end of the getAuthorInfo function. This will ensure consistency with the rest of the script and avoid any potential issues related to automatic semicolon insertion.

  • Locate the getAuthorInfo function in the file modules/ROOT/examples/live-demos/comments-callback/index.js.
  • Add a semicolon at the end of the function, after the closing curly brace on line 41.
Suggested changeset 1
modules/ROOT/examples/live-demos/comments-callback/index.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/modules/ROOT/examples/live-demos/comments-callback/index.js b/modules/ROOT/examples/live-demos/comments-callback/index.js
--- a/modules/ROOT/examples/live-demos/comments-callback/index.js
+++ b/modules/ROOT/examples/live-demos/comments-callback/index.js
@@ -40,3 +40,3 @@
   };
-}
+};
 
EOF
@@ -40,3 +40,3 @@
};
}
};

Copilot is powered by AI and may make mistakes. Always verify output.
@kemister85 kemister85 merged commit 8d07058 into tinymce/5 Apr 7, 2025
5 checks passed
@kemister85 kemister85 deleted the hotfix/5/DOC-3194 branch April 7, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants