Draft
Conversation
- Extract decorators/annotations from AST into node.extra["decorators"] for Python, Java/Kotlin/C#, and TypeScript - Expand framework decorator patterns from 8 to 24 (pytest, Django, Spring, Celery, NestJS, pydantic-ai agent tools, etc.) - Exclude dunder methods from dead code results - Skip classes referenced in function type annotations (Pydantic schemas) - Per-symbol IMPORTS_FROM edges for JS/TS/TSX named imports -- eliminates ~320 FPs from frontend codebases - ORM/framework base class exclusion (Base, DeclarativeBase, BaseModel, BaseSettings, etc.) - New entry point name patterns: upgrade/downgrade (Alembic), lifespan/get_db (FastAPI)
gzenz
force-pushed
the
fix/reduce-dead-code-false-positives
branch
from
9a17cd9 to
dea608f
Compare
tirth8205
reviewed
Apr 8, 2026
Owner
tirth8205
left a comment
tirth8205
left a comment
There was a problem hiding this comment.
Great improvement to dead code detection accuracy — expanding framework patterns from 8 to 22, excluding dunder methods, and using AST decorators are all valuable. 314 lines of new tests.
Please rebase on latest main. Once rebased and CI passes, we'll review for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node.extra["decorators"]for Python, Java/Kotlin/C#, and TypeScript -- enables framework entry point detection that was previously wired but never populated_FRAMEWORK_DECORATOR_PATTERNSfrom 8 to 22 patterns (pytest fixtures, Django signals, SQLAlchemy events, Celery tasks, Spring annotations, Flask/Starlette middleware, NestJS/Angular decorators)__init__,__str__, etc.) from dead code results -- runtime-invoked, never have explicit callersTest plan