fix(go): preserve generic receiver method ownership - #833
Open
merlincat11 wants to merge 2 commits into
Open
Conversation
code-review-graph reviewOverall risk: 0.30 (LOW) — 4 changed function(s)/class(es), 0 affected flow(s), 2 test gap(s) Risk-scored changes
Test gaps
Token savings: this graph-backed report used ~204,014 fewer tokens (~100%) than reading every changed file in full (estimated, chars/4 approximation). Powered by code-review-graph — local-first analysis; no code leaves the CI runner. |
merlincat11
marked this pull request as ready for review
August 8, 2026 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #832.
Go methods declared on generic receiver types were emitted as top-level
functions because the receiver parser did not unwrap
generic_typenodes.The fix unwraps generic and pointer receiver nodes to their base type
identifier, preserving method ownership for both
T[P]and*T[P]receivers.Validation
uv run --extra dev pytest -q— 2399 passed, 5 skipped, 2 xpasseduv run --extra dev ruff check code_review_graph/parser.py tests/test_multilang.pyinternal/addrs/graph.go: all 11DirectedGraph[T]methods now haveparent_name='DirectedGraph'.Repository-wide Ruff still reports unrelated pre-existing violations in other
test files.