fix(hooks,flows): prevent duplicate hooks on reinstall and resolve relative vs absolute path mismatch (#558, #569, #576) - #836
Open
Blazehue wants to merge 1 commit into
Conversation
…lative vs absolute path mismatch (tirth8205#558, tirth8205#569, tirth8205#576)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #558, #569, #576
Summary of Fixes
_merge_hooks_into_settingsincode_review_graph/skills.pyto update existingcode-review-graphhooks in-place, preventing duplicate hook entries when re-runningcode-review-graph install. Added regression testtest_install_hooks_reinstall_does_not_duplicate.incremental_trace_flows(code_review_graph/flows.py). Expandedchanged_filesto match both relative and absolute representations in SQL queries and entry point filtering (_matches_changed_files). Added regression testtest_incremental_trace_flows_relative_vs_absolute_path_mismatch.if False:,if TYPE_CHECKING:,#if 0) #576: Verified dead-code reachability guards (if False:,if TYPE_CHECKING:,#if 0,if (false)) so calls in statically dead branches produce noCALLSedges.Verification
pytest.